Skip to content

Commit

Permalink
added javadoc to IChemObjectReader explaining the split between ISimp…
Browse files Browse the repository at this point in the history
…le and IIterating ChemObjectReaders

Signed-off-by: Rajarshi Guha <rajarshi.guha@gmail.com>
  • Loading branch information
Jules Kerssemakers authored and rajarshi committed Jul 22, 2010
1 parent e6fecf2 commit 1574e42
Showing 1 changed file with 9 additions and 2 deletions.
11 changes: 9 additions & 2 deletions src/main/org/openscience/cdk/io/IChemObjectReader.java
Expand Up @@ -28,12 +28,19 @@
import org.openscience.cdk.exception.CDKException;

/**
* This class is the interface that all IO readers should implement.
*
* This interface specifies the common functionality all IO readers should provide.
*
* IO readers should not implement this interface directly, but rather implement

This comment has been minimized.

Copy link
@egonw

egonw Jul 22, 2010

Member

If you want the new paragraph to show up in the JavaDoc HTML too, you need to start with

...

* one of its child interfaces: {@link ISimpleChemObjectReader} or {@link org.openscience.cdk.io.iterator.IIteratingChemObjectReader}.
* These sub-interfaces specify the information access methods:
* a simple read() method for the {@link ISimpleChemObjectReader} and
* more advanced iterator based access for the {@link org.openscience.cdk.io.iterator.IIteratingChemObjectReader} (suitable for large files)
*

This comment has been minimized.

Copy link
@egonw

egonw Jul 22, 2010

Member

these lines lengths do not fit the GitHub review screen:

http://github.com/cdk/cdk/commit/1574e422084a2ade37901ea32c340c9e85d31bb4

Not sure about the exact length, and 120 is allowed by CDK, but I still prefer 80 chars per line most...

* @cdk.module io
* @cdk.githash
*
* @author Egon Willighagen <egonw@users.sf.net>
* @see ISimpleChemObjectReader, org.openscience.cdk.io.iterator.IIteratingChemObjectReader
**/
public interface IChemObjectReader extends IChemObjectIO {

Expand Down

0 comments on commit 1574e42

Please sign in to comment.